Pil0tXia commented on code in PR #4719:
URL: https://github.com/apache/eventmesh/pull/4719#discussion_r1554835069
##########
eventmesh-connectors/eventmesh-connector-rocketmq/build.gradle:
##########
@@ -16,21 +16,25 @@
*/
List rocketmq = [
- "org.apache.rocketmq:rocketmq-client:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-broker:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-common:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-store:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-namesrv:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-tools:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-remoting:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-logging:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-srvutil:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-filter:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-acl:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-srvutil:$rocketmq_version",
-
+ "org.apache.rocketmq:rocketmq-client:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-broker:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-common:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-store:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-namesrv:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-tools:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-remoting:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-logging:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-srvutil:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-filter:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-acl:${rocketmq_version}",
+ "org.apache.rocketmq:rocketmq-srvutil:${rocketmq_version}"
]
+configurations {
+ implementation.exclude group: "ch.qos.logback", module: "logback-classic"
+ implementation.exclude group: "ch.qos.logback", module: "logback-core"
+}
Review Comment:
If `configurations { runtimeClasspath {} }` block in the root project should
be able to avoid the transitive logging backend passed by direct dependencies
globally, then there's no need to exclude Logback again where the RocketMQ
dependencies are introduced.
Some `implementation.exclude` statements are removed (like
`eventmesh-connectors/eventmesh-connector-rabbitmq/build.gradle`) and I think
that's because `com.rabbitmq:amqp-client` won't introduce any logging backend
and these statements are redundant, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
