[
https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376861#comment-16376861
]
ASF GitHub Bot commented on FLINK-8694:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170574788
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -242,6 +239,22 @@ public boolean nextBufferIsEvent() {
return spilledView.nextBufferIsEvent();
}
+ @Override
+ public boolean isAvailable() {
+ synchronized (buffers) {
+ if (nextBuffer != null) {
+ return true;
+ }
+ else if (spilledView == null) {
+ return false;
+ }
+ } // else: spilled
+
+ checkState(spilledView != null, "No in-memory buffers
available, but also nothing spilled.");
--- End diff --
Maybe I see something wrong here, but isn't `spilledView` always non-`null`
here? In that case, please remove the check.
> Make notifyDataAvailable call reliable
> --------------------------------------
>
> Key: FLINK-8694
> URL: https://issues.apache.org/jira/browse/FLINK-8694
> Project: Flink
> Issue Type: Sub-task
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Blocker
>
> After FLINK-8591
> org.apache.flink.runtime.io.network.netty.SequenceNumberingViewReader#notifyDataAvailable
> (and the same for Credit base flow control) due to race condition can be
> sometimes ignored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
