[
https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376856#comment-16376856
]
ASF GitHub Bot commented on FLINK-8694:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170590385
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkThroughputBenchmarkTests.java
---
@@ -52,6 +52,14 @@ public void largeRemoteMode() throws Exception {
env.tearDown();
}
+ @Test
+ public void largeRemoteAlwaysFlush() throws Exception {
+ StreamNetworkThroughputBenchmark env = new
StreamNetworkThroughputBenchmark();
+ env.setUp(1, 1, 0, false);
+ env.executeBenchmark(1_000_000);
+ env.tearDown();
+ }
--- End diff --
Is this not tested via your non-IT tests now?
(we should be careful about adding integration/full stack tests because of
their added time)
> Make notifyDataAvailable call reliable
> --------------------------------------
>
> Key: FLINK-8694
> URL: https://issues.apache.org/jira/browse/FLINK-8694
> Project: Flink
> Issue Type: Sub-task
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Blocker
>
> After FLINK-8591
> org.apache.flink.runtime.io.network.netty.SequenceNumberingViewReader#notifyDataAvailable
> (and the same for Credit base flow control) due to race condition can be
> sometimes ignored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
