[
https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376859#comment-16376859
]
ASF GitHub Bot commented on FLINK-8694:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170589597
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -332,8 +332,8 @@ public void
testConsumeSpillablePartitionSpilledDuringConsume() throws Exception
//TODO: re-enable this?
// assertEquals(BUFFER_DATA_SIZE * 4 + 4,
partition.getTotalNumberOfBytes());
- listener.awaitNotifications(3, 30_000);
- assertEquals(3, listener.getNumNotifications());
+ listener.awaitNotifications(2, 30_000);
+ assertEquals(2, listener.getNumNotifications());
--- End diff --
note that we will be notified once the spilled writer completes
> Make notifyDataAvailable call reliable
> --------------------------------------
>
> Key: FLINK-8694
> URL: https://issues.apache.org/jira/browse/FLINK-8694
> Project: Flink
> Issue Type: Sub-task
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Blocker
>
> After FLINK-8591
> org.apache.flink.runtime.io.network.netty.SequenceNumberingViewReader#notifyDataAvailable
> (and the same for Credit base flow control) due to race condition can be
> sometimes ignored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
