[
https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377046#comment-16377046
]
ASF GitHub Bot commented on FLINK-8694:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170631511
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionView.java
---
@@ -219,6 +219,14 @@ public boolean nextBufferIsEvent() {
}
}
+ @Override
+ public synchronized boolean isAvailable() {
+ if (nextBuffer != null) {
+ return true;
+ }
+ return fileReader.hasReachedEndOfFile();
--- End diff --
should be `!fileReader.hasReachedEndOfFile();` - I will add tests in a
later PR for this
> Make notifyDataAvailable call reliable
> --------------------------------------
>
> Key: FLINK-8694
> URL: https://issues.apache.org/jira/browse/FLINK-8694
> Project: Flink
> Issue Type: Sub-task
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Blocker
>
> After FLINK-8591
> org.apache.flink.runtime.io.network.netty.SequenceNumberingViewReader#notifyDataAvailable
> (and the same for Credit base flow control) due to race condition can be
> sometimes ignored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
