[
https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376909#comment-16376909
]
ASF GitHub Bot commented on FLINK-8694:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5572#discussion_r170600612
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
---
@@ -206,7 +201,7 @@ public String toString() {
return "CreditBasedSequenceNumberingViewReader{" +
"requestLock=" + requestLock +
", receiverId=" + receiverId +
- ", buffersAvailable=" + buffersAvailable.get() +
+ ", buffersAvailable=" + hasBuffersAvailable() +
--- End diff --
this line should now be removed (the property is not part of this object
anymore and going through a synchronized block which may be nasty during
debugging sessions)
> Make notifyDataAvailable call reliable
> --------------------------------------
>
> Key: FLINK-8694
> URL: https://issues.apache.org/jira/browse/FLINK-8694
> Project: Flink
> Issue Type: Sub-task
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Blocker
>
> After FLINK-8591
> org.apache.flink.runtime.io.network.netty.SequenceNumberingViewReader#notifyDataAvailable
> (and the same for Credit base flow control) due to race condition can be
> sometimes ignored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
