[ 
https://issues.apache.org/jira/browse/FLINK-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376862#comment-16376862
 ] 

ASF GitHub Bot commented on FLINK-8694:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5572#discussion_r170585362
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationHeadTask.java
 ---
    @@ -447,6 +447,8 @@ private void sendEndOfSuperstepToAllIterationOutputs() 
throws IOException, Inter
     
                for (RecordWriter<?> eventualOutput : this.eventualOutputs) {
                        
eventualOutput.broadcastEvent(EndOfSuperstepEvent.INSTANCE);
    +                   eventualOutput.clearBuffers();
    +                   eventualOutput.flushAll();
    --- End diff --
    
    let's remove those two - they should be unnecessary


> Make notifyDataAvailable call reliable
> --------------------------------------
>
>                 Key: FLINK-8694
>                 URL: https://issues.apache.org/jira/browse/FLINK-8694
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>            Priority: Blocker
>
> After FLINK-8591 
> org.apache.flink.runtime.io.network.netty.SequenceNumberingViewReader#notifyDataAvailable
>  (and the same for Credit base flow control) due to race condition can be 
> sometimes ignored. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to