[GitHub] flink pull request #5672: [FLINK-8872][flip6] fix yarn detached mode command...

[StefanRRichter]

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5672#discussion_r174194372
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/cli/Flip6DefaultCLI.java ---
    @@ -40,6 +40,7 @@ public Flip6DefaultCLI(Configuration configuration) {
     
        @Override
        public boolean isActive(CommandLine commandLine) {
    +           this.detachedMode = 
commandLine.hasOption(CliFrontendParser.DETACHED_OPTION.getOpt());
    --- End diff --
    
    Why not introduce an abstract method `isDetached(CommandLine)` in 
`CustomCommandLine`?


---