[
https://issues.apache.org/jira/browse/FLINK-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713429#comment-14713429
]
ASF GitHub Bot commented on FLINK-2399:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37981839
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -205,7 +205,7 @@ public static void submitJobDetached(
Preconditions.checkNotNull(timeout, "The timeout must not be
null.");
Future<Object> future = jobManagerGateway.ask(
- new JobManagerMessages.SubmitJob(jobGraph,
false),
+ new JobManagerMessages.SubmitJob(jobGraph,
false, jobGraph.getClientVersion()),
--- End diff --
Why don't you simply use the `getImplementationVersion` of the `JobClient`
but the version of the `Configuration` which is part of the `jobGraph` instance?
> Fail when actor versions don't match
> ------------------------------------
>
> Key: FLINK-2399
> URL: https://issues.apache.org/jira/browse/FLINK-2399
> Project: Flink
> Issue Type: Improvement
> Components: JobManager, TaskManager
> Affects Versions: 0.9, master
> Reporter: Ufuk Celebi
> Assignee: Sachin Goel
> Priority: Minor
> Fix For: 0.10
>
>
> Problem: there can be subtle errors when actors from different Flink versions
> communicate with each other, for example when an old client (e.g. Flink 0.9)
> communicates with a new JobManager (e.g. Flink 0.10-SNAPSHOT).
> We can check that the versions match on first communication between the
> actors and fail if they don't match.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
