[ 
https://issues.apache.org/jira/browse/FLINK-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713562#comment-14713562
 ] 

ASF GitHub Bot commented on FLINK-2399:
---------------------------------------

Github user sachingoel0101 commented on the pull request:

    https://github.com/apache/flink/pull/945#issuecomment-135045372
  
    Hi @tillrohrmann , thanks for the review. You're right. `getClass...` is 
not the right way to go. I had decided to just use this for the moment. We can 
certainly have a better version numbering for this purpose, to ensure the 
actors are compatible.
    I just am not sure if having a version string, which needs to be managed 
directly in the source code is a good idea. For example, it would make sense to 
extract the first digit, 0.9, 0.10 etc. since the minor bug fix releases are 
otherwise compatible anyway. 


> Fail when actor versions don't match
> ------------------------------------
>
>                 Key: FLINK-2399
>                 URL: https://issues.apache.org/jira/browse/FLINK-2399
>             Project: Flink
>          Issue Type: Improvement
>          Components: JobManager, TaskManager
>    Affects Versions: 0.9, master
>            Reporter: Ufuk Celebi
>            Assignee: Sachin Goel
>            Priority: Minor
>             Fix For: 0.10
>
>
> Problem: there can be subtle errors when actors from different Flink versions 
> communicate with each other, for example when an old client (e.g. Flink 0.9) 
> communicates with a new JobManager (e.g. Flink 0.10-SNAPSHOT).
> We can check that the versions match on first communication between the 
> actors and fail if they don't match.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to