[
https://issues.apache.org/jira/browse/FLINK-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713543#comment-14713543
]
ASF GitHub Bot commented on FLINK-2399:
---------------------------------------
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r37989214
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -54,8 +54,12 @@
/** Stores the concrete key/value pairs of this configuration object. */
- private final HashMap<String, Object> confData;
-
+ private final Map<String, Object> confData;
+
+ /** Stores the program version */
+ public final String FLINK_VERSION =
getClass().getPackage().getImplementationVersion() ==
+ null ? "FLINK_TEST_VERSION" :
getClass().getPackage().getImplementationVersion();
--- End diff --
Ah yes. I had not considered this. In this case, the client version would
be null.
As for ensuring that compatible versions still work, you're right. This is
why I'm not in favor of using the current version string. A better approach
would be to have specific release versions in the configuration file, from
where everything starts.`
> Fail when actor versions don't match
> ------------------------------------
>
> Key: FLINK-2399
> URL: https://issues.apache.org/jira/browse/FLINK-2399
> Project: Flink
> Issue Type: Improvement
> Components: JobManager, TaskManager
> Affects Versions: 0.9, master
> Reporter: Ufuk Celebi
> Assignee: Sachin Goel
> Priority: Minor
> Fix For: 0.10
>
>
> Problem: there can be subtle errors when actors from different Flink versions
> communicate with each other, for example when an old client (e.g. Flink 0.9)
> communicates with a new JobManager (e.g. Flink 0.10-SNAPSHOT).
> We can check that the versions match on first communication between the
> actors and fail if they don't match.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
