[
https://issues.apache.org/jira/browse/FLINK-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713447#comment-14713447
]
ASF GitHub Bot commented on FLINK-2399:
---------------------------------------
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/945#issuecomment-135026427
I had some comments concerning the implementation. I think as a first step
we should not check whether the JM and TM have the same versions because in
nearly all cases both classes will be started from the same binaries. If we
should decide at a later point that we want to check that all used actors are
compatible, then I would vote for using the decoration mechanism to
transparently add a version ID instead of adding it manually to a subset of
messages. The latter approach is IMO error-prone.
Checking whether the client and the JM have compatible versions should be
sufficient. I'm not quite sure whether
`getClass().getPackage().getImplementationVersion()` is the right way to go
here. Using this function won't allow compatible versions which only differ in
a minor version number to work together. IMHO, this should be allowed.
> Fail when actor versions don't match
> ------------------------------------
>
> Key: FLINK-2399
> URL: https://issues.apache.org/jira/browse/FLINK-2399
> Project: Flink
> Issue Type: Improvement
> Components: JobManager, TaskManager
> Affects Versions: 0.9, master
> Reporter: Ufuk Celebi
> Assignee: Sachin Goel
> Priority: Minor
> Fix For: 0.10
>
>
> Problem: there can be subtle errors when actors from different Flink versions
> communicate with each other, for example when an old client (e.g. Flink 0.9)
> communicates with a new JobManager (e.g. Flink 0.10-SNAPSHOT).
> We can check that the versions match on first communication between the
> actors and fail if they don't match.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
