[ 
https://issues.apache.org/jira/browse/FLINK-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713547#comment-14713547
 ] 

ASF GitHub Bot commented on FLINK-2399:
---------------------------------------

Github user sachingoel0101 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/945#discussion_r37989473
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
 ---
    @@ -547,7 +552,7 @@ class TaskManager(
     
             // successful registration. associate with the JobManager
             // we disambiguate duplicate or erroneous messages, to simplify 
debugging
    -        case AcknowledgeRegistration(_, leaderSessionID, jobManager, id, 
blobPort) =>
    +        case AcknowledgeRegistration(_, leaderSessionID, jobManager, id, 
blobPort, jobManagerID) =>
    --- End diff --
    
    But the initial registration must have happened with 
`AcknowledgeRegistration`, right? Correct me if I'm wrong.


> Fail when actor versions don't match
> ------------------------------------
>
>                 Key: FLINK-2399
>                 URL: https://issues.apache.org/jira/browse/FLINK-2399
>             Project: Flink
>          Issue Type: Improvement
>          Components: JobManager, TaskManager
>    Affects Versions: 0.9, master
>            Reporter: Ufuk Celebi
>            Assignee: Sachin Goel
>            Priority: Minor
>             Fix For: 0.10
>
>
> Problem: there can be subtle errors when actors from different Flink versions 
> communicate with each other, for example when an old client (e.g. Flink 0.9) 
> communicates with a new JobManager (e.g. Flink 0.10-SNAPSHOT).
> We can check that the versions match on first communication between the 
> actors and fail if they don't match.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to