[
https://issues.apache.org/jira/browse/FLINK-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14714398#comment-14714398
]
ASF GitHub Bot commented on FLINK-2399:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/945#discussion_r38000188
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -524,13 +534,24 @@ class JobManager(
* @param listenToEvents true if the sender wants to listen to job
status and execution state
* change notifications. false if not.
*/
- private def submitJob(jobGraph: JobGraph, listenToEvents: Boolean): Unit
= {
+ private def submitJob(
+ jobGraph: JobGraph,
+ listenToEvents: Boolean,
+ clientVersion: String)
+ : Unit = {
if (jobGraph == null) {
sender ! decorateMessage(
Failure(
new JobSubmissionException(null, "JobGraph must not be null.")
)
)
+ } else if(jobManagerVersionID != clientVersion){
+ sender ! decorateMessage(
+ Failure(
+ new JobSubmissionException(jobGraph.getJobID, "Client version
mismatches that of Job " +
+ "Manager.")
--- End diff --
Yeah I know, but it might be interesting for the user who sees the
`JobSubmissionException` to know the exact version.
> Fail when actor versions don't match
> ------------------------------------
>
> Key: FLINK-2399
> URL: https://issues.apache.org/jira/browse/FLINK-2399
> Project: Flink
> Issue Type: Improvement
> Components: JobManager, TaskManager
> Affects Versions: 0.9, master
> Reporter: Ufuk Celebi
> Assignee: Sachin Goel
> Priority: Minor
> Fix For: 0.10
>
>
> Problem: there can be subtle errors when actors from different Flink versions
> communicate with each other, for example when an old client (e.g. Flink 0.9)
> communicates with a new JobManager (e.g. Flink 0.10-SNAPSHOT).
> We can check that the versions match on first communication between the
> actors and fail if they don't match.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
