StephanEwen commented on a change in pull request #8704: [FLINK-12812][runtime]
Set resource profiles for task slots
URL: https://github.com/apache/flink/pull/8704#discussion_r300063436
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -358,14 +384,14 @@ private static MemoryManager createMemoryManager(
float memoryFraction =
taskManagerServicesConfiguration.getMemoryFraction();
if (memType == MemoryType.HEAP) {
- long freeHeapMemoryWithDefrag =
taskManagerServicesConfiguration.getFreeHeapMemoryWithDefrag();
- // network buffers allocated off-heap -> use
memoryFraction of the available heap:
- long relativeMemSize = (long)
(freeHeapMemoryWithDefrag * memoryFraction);
+ long maxJvmHeapMemory =
taskManagerServicesConfiguration.getMaxJvmHeapMemory();
Review comment:
This changes how the TaskManager determines its memory pools. This may
suddenly break programs that now run out of heap, or it may slow down programs
due to garbage collection issues, because more memory is given to managed
memory.
Such a change cannot be done as a small part hidden in a new feature, this
needs to be an separate change with a discussion up front.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
