StephanEwen commented on a change in pull request #8704: [FLINK-12812][runtime]
Set resource profiles for task slots
URL: https://github.com/apache/flink/pull/8704#discussion_r300061789
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##########
@@ -325,6 +319,38 @@ public static TaskManagerServices fromConfiguration(
.createShuffleEnvironment(shuffleEnvironmentContext);
}
+ private static TaskSlotTable createTaskSlotTable(
+ TaskManagerServicesConfiguration
taskManagerServicesConfiguration,
+ long managedMemorySize) {
+
+ final int numOfSlots =
taskManagerServicesConfiguration.getNumberOfSlots();
+ final long heapMemoryBytesPerSlot =
(taskManagerServicesConfiguration.getMemoryType() == MemoryType.HEAP ?
Review comment:
It looks like heap memory resource is not used anywhere at the moment.
The logic also seems a bit ad-hoc: Divide all JVM heap by slots. What about
the overhead of the TM components themselves (akka, netty, etc).
If this is not used anywhere at the moment, I would not add this, especially
if it is not tested at the moment and not documented what the behavior is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
