StephanEwen commented on a change in pull request #8704: [FLINK-12812][runtime]
Set resource profiles for task slots
URL: https://github.com/apache/flink/pull/8704#discussion_r300069797
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -1845,6 +1860,42 @@ public void
testSlotReportDoesNotContainStaleInformation() throws Exception {
}
}
+ @Test
+ public void testSlotReportResourceProfile() throws Throwable {
Review comment:
I think this test shows that the abstractions are too intermingled.
The code that was added in TaskExecutor was a change to replace the UNKNOWN
profile attached to a slot by a profile with proper values. The code only takes
the task manager's config (or managed memory size), and determines the size of
the slots.
Such a change should not need the creation of a full TaskExecutor to test
it. That means something is not right in the abstraction.
This test setup means that every time the TaskExecutor setup changes, the
test for the simple code "config -> profile" needs to be adjusted, which
contributes to making maintenance complex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
