StephanEwen commented on a change in pull request #8704: [FLINK-12812][runtime] Set resource profiles for task slots URL: https://github.com/apache/flink/pull/8704#discussion_r300067339
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java ########## @@ -258,20 +259,13 @@ public static TaskManagerServices fromConfiguration( // this call has to happen strictly after the network stack has been initialized final MemoryManager memoryManager = createMemoryManager(taskManagerServicesConfiguration); + final long managedMemorySize = memoryManager.getMemorySize(); final BroadcastVariableManager broadcastVariableManager = new BroadcastVariableManager(); - final List<ResourceProfile> resourceProfiles = new ArrayList<>(taskManagerServicesConfiguration.getNumberOfSlots()); Review comment: This also allows for targeted testing of the resource computation code, which avoids many of the complexity of the new tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services