StephanEwen commented on a change in pull request #8704: [FLINK-12812][runtime]
Set resource profiles for task slots
URL: https://github.com/apache/flink/pull/8704#discussion_r300066351
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1621,6 +1621,11 @@ TaskExecutorToResourceManagerConnection
getResourceManagerConnection() {
return resourceManagerHeartbeatManager;
}
+ @VisibleForTesting
+ SlotReport getSlotReport() {
Review comment:
You can probably drop this method if you move the code that computes the
slot resources into a separate method:
`computeSlotResourceProfile(taskManagerServicesConfiguration)` as suggested.
Then you can test that logic in isolation and do not need access to the slot
requests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
