StephanEwen commented on a change in pull request #8704: [FLINK-12812][runtime]
Set resource profiles for task slots
URL: https://github.com/apache/flink/pull/8704#discussion_r300038924
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
##########
@@ -284,12 +301,39 @@ else if (obj != null && obj.getClass() ==
ResourceProfile.class) {
return this.cpuCores == that.cpuCores &&
this.heapMemoryInMB ==
that.heapMemoryInMB &&
this.directMemoryInMB ==
that.directMemoryInMB &&
+ this.nativeMemoryInMB ==
that.nativeMemoryInMB &&
Review comment:
If this is a separate bug fix, it should typically go into a separate commit.
Seems that this class could also use some better tests ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
