StephanEwen commented on a change in pull request #8704: [FLINK-12812][runtime]
Set resource profiles for task slots
URL: https://github.com/apache/flink/pull/8704#discussion_r300068029
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -1729,14 +1738,16 @@ public void testSyncSlotsWithJobMasterByHeartbeat()
throws Exception {
final AllocationID allocationIdOnlyInJM = new
AllocationID();
final AllocationID allocationIdOnlyInTM = new
AllocationID();
- taskExecutorGateway.requestSlot(slotId1, jobId,
allocationIdInBoth, "foobar", testingResourceManagerGateway.getFencingToken(),
timeout);
- taskExecutorGateway.requestSlot(slotId2, jobId,
allocationIdOnlyInTM, "foobar",
testingResourceManagerGateway.getFencingToken(), timeout);
+ taskExecutorGateway.requestSlot(slotId1, jobId,
allocationIdInBoth, "foobar",
Review comment:
Lots of unrelated reformatting. Per Flink coding guides, these should be
done in a change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
