davidradl commented on code in PR #25952:
URL: https://github.com/apache/flink/pull/25952#discussion_r1910652096
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/catalog/JavaCatalogTableTest.java:
##########
@@ -177,6 +177,31 @@ void testTimeAttributeOfView() {
+ "GROUP BY window_start, window_end");
}
+ @TestTemplate
+ void testTimeAttributeOfViewSelect() {
+ if (!streamingMode) {
+ // time attributes not supported in batch
+ return;
+ }
+ TableTestUtil testUtil = getTestUtil();
+ TableEnvironment tableEnvironment = testUtil.getTableEnv();
Review Comment:
someone in our team tested and the test works before the fix. Is there a
test that would have failed before the fix and now passes after your fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
