stack commented on HBASE-15789:

Should this be protected rather than default?

          static byte[] getOrCreateBuffer(int requestedSize) {

What do they usually do in this case?

Trying to make sure this patch gets taken upstream (smile).

The class comment looks like it needs beefing up compared to ByteOutput javadoc 
but we can do that later.

This method seems unnecessary:

public int read(int offset, byte b[]) throws IOException {

Do we need a readLazy to go w/ the ByteOutput writeLazy?

Is the size needed? A buffer will always have a size?

Is there a ByteOutput version of ByteInputByteString ?

They do this stuff in pb classes?

  // =================================================================

Did you try ByteInput with a ByteBuf offheap?

Skimmed. Its a big patch.

Good one.

> PB related changes to work with offheap
> ---------------------------------------
>                 Key: HBASE-15789
>                 URL: https://issues.apache.org/jira/browse/HBASE-15789
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>         Attachments: HBASE-15789.patch
> This is an issue to brainstorm. Whether we go with pb 2.x or pb 3.0 and also 
> depends on the shading of protobuf classes. 
> We should also decide if we are going to fork the PB classes.

This message was sent by Atlassian JIRA

Reply via email to