[
https://issues.apache.org/jira/browse/HBASE-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575914#comment-15575914
]
stack commented on HBASE-15789:
-------------------------------
What did you do regards mvn package? Where did you check in your classes? The
-Pgenerate-shaded-classes profile pulls down the protobuf jar, shades it, then
copies the shaded java files over to src/main/java for checkin. I think we need
to apply your patch on top of the copy. I was thinking of using the maven patch
plugin to do this. If you have something more straight-forward, I'm all ears.
Yeah, would be good to shove something upstream just to get the discussion
going. Maybe even get it in for 3.2?
> PB related changes to work with offheap
> ---------------------------------------
>
> Key: HBASE-15789
> URL: https://issues.apache.org/jira/browse/HBASE-15789
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
> Reporter: ramkrishna.s.vasudevan
> Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-15789.patch, HBASE-15789_V2.patch
>
>
> This is an issue to brainstorm. Whether we go with pb 2.x or pb 3.0 and also
> depends on the shading of protobuf classes.
> We should also decide if we are going to fork the PB classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
