stack commented on HBASE-15789:

bq. As it is static I thought default is make sense than protected

Was more asking about how pb does it internally. They do package private or 

bq. Just added it to look some what like IS ...

Suggest leave it off. This is not an IS. Keep it small. But do you need it for 
CIS? If so, leave it.

Ok on leaving out readLazy.

Nice that you did an implementation and its working....

Push upstream sooner rather than later?

Should I work on making it so we can patch this into our version of pbs? Would 
to it as part of the protoc step over in hbase-protocol-shaded.

> PB related changes to work with offheap
> ---------------------------------------
>                 Key: HBASE-15789
>                 URL: https://issues.apache.org/jira/browse/HBASE-15789
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>         Attachments: HBASE-15789.patch, HBASE-15789_V2.patch
> This is an issue to brainstorm. Whether we go with pb 2.x or pb 3.0 and also 
> depends on the shading of protobuf classes. 
> We should also decide if we are going to fork the PB classes.

This message was sent by Atlassian JIRA

Reply via email to