stack commented on HBASE-15789:

bq. Even the new classes in the patch can be inside src/patches/xxx.patch file?


bq. So when dev download src code and setup in IDE, this step will happen so 
that they can see these patches classes right?

No. The patch is applied as part of the -Pgenerate-shaded-classes step done 
when you change protobuf or if you change these patches or if you change the 
protobuf version.

Let me commit this. Means checking in this new facility, your patch as is, and 
then after running the -Pgenerate-shaded-classes step, all the changes (patched 
protobuf lib in this case).

> PB related changes to work with offheap
> ---------------------------------------
>                 Key: HBASE-15789
>                 URL: https://issues.apache.org/jira/browse/HBASE-15789
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>         Attachments: HBASE-15789.master.001.patch, HBASE-15789.patch, 
> HBASE-15789_V2.patch
> This is an issue to brainstorm. Whether we go with pb 2.x or pb 3.0 and also 
> depends on the shading of protobuf classes. 
> We should also decide if we are going to fork the PB classes.

This message was sent by Atlassian JIRA

Reply via email to