Anoop Sam John commented on HBASE-15789:

bq.Was more asking about how pb does it internally. They do package private or 
Within this class, we can see the APIs externally getting used are marked 
package private. 
static void write(ByteBuffer buffer, OutputStream output) throws IOException
static void clearCachedBuffer()
So this should be ok for them I believe.
bq.Suggest leave it off. This is not an IS. Keep it small. But do you need it 
for CIS? If so, leave it.
Just am internally using it in readString() etc. But its ok other API also can 
be used by passing 0 offset and proper length. Will remove then.
Push upstream sooner rather than later?
Should I work on making it so we can patch this into our version of pbs? Would 
to it as part of the protoc step over in hbase-protocol-shaded.
Ya can do.  We can get this committed to our shaded project thats it no?  We 
will compile the classes there.  When I did test here I just did mvn package 
and it included the new classes also in the PB created jar.

> PB related changes to work with offheap
> ---------------------------------------
>                 Key: HBASE-15789
>                 URL: https://issues.apache.org/jira/browse/HBASE-15789
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>         Attachments: HBASE-15789.patch, HBASE-15789_V2.patch
> This is an issue to brainstorm. Whether we go with pb 2.x or pb 3.0 and also 
> depends on the shading of protobuf classes. 
> We should also decide if we are going to fork the PB classes.

This message was sent by Atlassian JIRA

Reply via email to