bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r686197890
##########
File path:
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
##########
@@ -291,17 +292,19 @@ public void removeRSGroup(RpcController controller,
@Override
public void balanceRSGroup(RpcController controller,
BalanceRSGroupRequest request, RpcCallback<BalanceRSGroupResponse>
done) {
+ BalanceRequest balanceRequest =
RSGroupProtobufUtil.toBalanceRequest(request);
+
BalanceRSGroupResponse.Builder builder =
BalanceRSGroupResponse.newBuilder();
LOG.info(master.getClientIdAuditPrefix() + " balance rsgroup, group="
+ request.getRSGroupName());
try {
- if (master.getMasterCoprocessorHost() != null) {
+ if (master.getMasterCoprocessorHost() != null &&
!balanceRequest.isDryRun()) {
Review comment:
Ok sounds good. I'll look into doing it here and if it's too much of a
change we can go the TODO route.
Yea I think minor version is fine. I'm going to backport this to our fork
once merged anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
