bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r686204241
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1750,10 +1751,16 @@ public boolean skipRegionManagementAction(final String
action) {
return false;
}
- public boolean balance(boolean force) throws IOException {
- if (loadBalancerTracker == null || !loadBalancerTracker.isBalancerOn()) {
+ public boolean balance(BalanceRequest request) throws IOException {
+ return balance(request, false);
+ }
+
+ private boolean balance(BalanceRequest request, boolean isChore) throws
IOException {
Review comment:
Actually to be honest this was just an artifact of some interface
evolutions that have occurred on this PR. I'm fine leaving it out. I do think
sometimes it would be helpful to differentiate between the chore and manual,
but I'm not sure this line would be the most important or only one. I'll leave
this out for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
