ndimiduk commented on pull request #3536: URL: https://github.com/apache/hbase/pull/3536#issuecomment-896310253
@bbeaudreault > I've pushed a commit which covers two outcomes from the latest round Great, thank you! > Are you ok with my leaving the `ignore_rit` rename in Master.proto? I submitted the DISCUSS thread, but not sure if that's a blocker here. I personally like the new field name better ; I think it is a nice improvement. No other reviewer has commented on it, so it's up to the two of us ;) I suggest you retain the change in this PR while the DISCUSS thread settles. We will need to come to a conclusion before 2.5.0 can be released, so it's an important one to keep track of. > What are your thoughts on our ability to easily change the new Admin method `boolean balance(BalanceRequest request) throws IOException` to something like `BalanceResponse balance(BalanceRequest request) throws IOException` in the future? These changes to just the return value are a real hassle in Java. If we're going to pursue the rich response value, I think we need to add it now. Well, "now" meaning before 2.5.0, when this new `balance(BalanceRequest)` signature is released to the public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
