bbeaudreault commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r686234406
##########
File path:
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java
##########
@@ -291,17 +292,19 @@ public void removeRSGroup(RpcController controller,
@Override
public void balanceRSGroup(RpcController controller,
BalanceRSGroupRequest request, RpcCallback<BalanceRSGroupResponse>
done) {
+ BalanceRequest balanceRequest =
RSGroupProtobufUtil.toBalanceRequest(request);
+
BalanceRSGroupResponse.Builder builder =
BalanceRSGroupResponse.newBuilder();
LOG.info(master.getClientIdAuditPrefix() + " balance rsgroup, group="
+ request.getRSGroupName());
try {
- if (master.getMasterCoprocessorHost() != null) {
+ if (master.getMasterCoprocessorHost() != null &&
!balanceRequest.isDryRun()) {
Review comment:
It ended up being pretty easy to modify the interface, so I did that
here since we're already in the "requires minor version" territory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
