chenjunjiedada commented on a change in pull request #588: [WIP] Add sequence 
number for supporting row level delete
URL: https://github.com/apache/incubator-iceberg/pull/588#discussion_r374813166
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/SnapshotProducer.java
 ##########
 @@ -244,6 +246,9 @@ public void commit() {
               updated = base.replaceCurrentSnapshot(newSnapshot);
             }
 
+            // reset sequence number to null so that the sequence number can 
be updated when retry
+            this.sequenceNumber = null;
 
 Review comment:
   Because the sequence number cannot be unique, so it has to reset to null for 
next use.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to