chenjunjiedada commented on a change in pull request #588: [WIP] Add sequence 
number for supporting row level delete
URL: https://github.com/apache/incubator-iceberg/pull/588#discussion_r374814764
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/FastAppend.java
 ##########
 @@ -137,7 +147,7 @@ private ManifestFile writeManifest() throws IOException {
     if (newManifest == null && newFiles.size() > 0) {
       OutputFile out = manifestPath(manifestCount.getAndIncrement());
 
-      ManifestWriter writer = new ManifestWriter(spec, out, snapshotId());
+      ManifestWriter writer = new ManifestWriter(spec, out, snapshotId(), 
sequenceNumber());
 
 Review comment:
   I should misunderstand the logic, please ignore this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to