chenjunjiedada commented on a change in pull request #588: [WIP] Add sequence 
number for supporting row level delete
URL: https://github.com/apache/incubator-iceberg/pull/588#discussion_r376685537
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/GenericManifestFile.java
 ##########
 @@ -137,6 +138,26 @@ public GenericManifestFile(String path, long length, int 
specId, Long snapshotId
     this.fromProjectionPos = null;
   }
 
+  public GenericManifestFile(String path, long length, int specId, Long 
snapshotId, Long sequenceNumber,
 
 Review comment:
   Agreed, no place uses it actually.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to