chenjunjiedada commented on a change in pull request #588: [WIP] Add sequence
number for supporting row level delete
URL: https://github.com/apache/incubator-iceberg/pull/588#discussion_r374812448
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -682,7 +692,8 @@ private ManifestFile createManifest(int specId,
List<ManifestFile> bin) throws I
writer.close();
}
- ManifestFile manifest = writer.toManifestFile();
+ ManifestFile manifest = GenericManifestFile.copyOf(writer.toManifestFile())
Review comment:
The new created manifest needs sequence number since the previously new
added manifests maybe rewrite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
