chenjunjiedada commented on a change in pull request #588: [WIP] Add sequence
number for supporting row level delete
URL: https://github.com/apache/incubator-iceberg/pull/588#discussion_r376683881
##########
File path: api/src/main/java/org/apache/iceberg/DataFile.java
##########
@@ -152,4 +153,11 @@ static StructType getType(StructType partitionType) {
* are determined by these offsets. The returned list must be sorted in
ascending order.
*/
List<Long> splitOffsets();
+
+ /**
+ * @return The sequence number to identify the order in which data files and
deletion files are to be processed.
+ * If the sequence number is not specified it is inherited from the manifest
file struct in the manifest list file.
+ */
+ Long sequenceNumber();
Review comment:
I use boxing here because I don't want to rewrite the manifest file. The
sequence number is not determined when committing the update, leave it to null
so that we can inherit the sequence number from the value in the manifest list
file.
If we use the primitive type, we need to check where the sequence number of
the manifest is null or not. It should be doable, let me update this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
