chenjunjiedada commented on a change in pull request #588: [WIP] Add sequence
number for supporting row level delete
URL: https://github.com/apache/incubator-iceberg/pull/588#discussion_r376685087
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
##########
@@ -146,7 +146,7 @@ public RewriteManifests addManifest(ManifestFile manifest)
{
if (snapshotIdInheritanceEnabled && manifest.snapshotId() == null) {
addedManifests.add(manifest);
} else {
- // the manifest must be rewritten with this update's snapshot ID
+ // the manifest must be rewritten with this update's snapshot ID and
sequence number
Review comment:
You are right. When the commit fails, it just needs to update the sequence
number in the manifest list file and doesn't have to keep sequence number in
the manifest file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
