bryanck commented on code in PR #8381:
URL: https://github.com/apache/iceberg/pull/8381#discussion_r1306084751
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -124,7 +124,7 @@ static TableMetadata newTableMetadata(
MetricsConfig.fromProperties(properties).validateReferencedColumns(schema);
return new Builder()
- .upgradeFormatVersion(formatVersion)
+ .setFormatVersion(formatVersion)
Review Comment:
I feel like `upgradeFormatVersion` (despite the name) might be more
consistent the other setters, which perform checks and add the MetadataUpdate
as needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
