aokolnychyi commented on code in PR #8381:
URL: https://github.com/apache/iceberg/pull/8381#discussion_r1308060649
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -124,7 +124,7 @@ static TableMetadata newTableMetadata(
MetricsConfig.fromProperties(properties).validateReferencedColumns(schema);
return new Builder()
- .upgradeFormatVersion(formatVersion)
+ .setFormatVersion(formatVersion)
Review Comment:
I don't think the validation in `upgradeFormatVersion` is applicable when
creating new tables. I also don't think we are supposed to generate an update
cause we are not updating the format version, the table does not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
