RussellSpitzer commented on code in PR #8381:
URL: https://github.com/apache/iceberg/pull/8381#discussion_r1306097790
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -965,6 +965,13 @@ public Builder assignUUID(String newUuid) {
return this;
}
+ // it is only safe to set the format version directly while creating tables
+ // in all other cases, use the method below to safely upgrade the format
version
+ private Builder setFormatVersion(int newFormatVersion) {
Review Comment:
The doc comment here is confusing since the method is write below here, I
think you should say "in all other cases, use upgradeFormatVersion.
We also could try to encapsulate some of this doc into the method name?
newTableFormatVersion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
