RussellSpitzer commented on code in PR #8381:
URL: https://github.com/apache/iceberg/pull/8381#discussion_r1306107997
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -127,6 +129,40 @@ public void testReplaceTxnBuilder() throws Exception {
.containsEntry("key2", "value2");
}
+ @Test
+ public void testReplaceTxnBuilderDefaultFormatVersion() throws Exception {
+ HadoopCatalog catalog = hadoopCatalog();
+ TableIdentifier tableIdent = TableIdentifier.of("db", "ns1", "ns2", "tbl");
+
+ Transaction createTxn =
+ catalog
+ .buildTable(tableIdent, SCHEMA)
+ .withPartitionSpec(SPEC)
+ .withProperty("key1", "value1")
+ .createOrReplaceTransaction();
+
+ createTxn.newAppend().appendFile(FILE_A).commit();
Review Comment:
nit: but we could refactor all this out since it's all identical except for
the version. Not a big deal now, but maybe makes sense since we'll have a "V3"
soon enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
