RussellSpitzer commented on code in PR #8381:
URL: https://github.com/apache/iceberg/pull/8381#discussion_r1306112261
##########
spark/v3.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAlterTablePartitionFields.java:
##########
@@ -301,17 +284,33 @@ public void testReplacePartition() {
sql("ALTER TABLE %s ADD PARTITION FIELD days(ts)", tableName);
table.refresh();
PartitionSpec expected =
-
PartitionSpec.builderFor(table.schema()).withSpecId(1).day("ts").build();
Review Comment:
We do we need to do the change here? I'm not a big fan of have String
constants for expected values, even if we are parsing them into a friendly
object for comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
