openinx commented on a change in pull request #1125:
URL: https://github.com/apache/iceberg/pull/1125#discussion_r445629141
##########
File path:
data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetReaders.java
##########
@@ -396,7 +409,12 @@ private FixedReader(ColumnDescriptor desc) {
}
}
- static class RecordReader extends StructReader<Record, Record> {
+ public interface StructReaderFactory<T> {
+
+ StructReader<T, T> create(List<Type> types, List<ParquetValueReader<?>>
readers, StructType struct);
+ }
+
+ static class RecordReader extends StructReader<GenericRecord, GenericRecord>
{
Review comment:
I changed this because the `buildReader` method return the
`GenericRecord` ParquetValueReader. Seems better to change the
ParquetValueReader to be `Record` reader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
