rdblue commented on a change in pull request #1125:
URL: https://github.com/apache/iceberg/pull/1125#discussion_r446305198
##########
File path: data/src/test/java/org/apache/iceberg/data/RandomGenericData.java
##########
@@ -55,11 +55,9 @@ private RandomGenericData() {}
return records;
}
- private static class RandomDataGenerator extends
TypeUtil.CustomOrderSchemaVisitor<Object> {
- private final Random random;
-
- private RandomDataGenerator(long seed) {
- this.random = new Random(seed);
+ private static class RandomRecordDataGenerator extends
RandomDataGenerator<Record> {
Review comment:
How about `RandomRecordGenerator` instead of
`RandomRecordDataGenerator`? I think that's more descriptive since it returns
random records.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
