openinx commented on a change in pull request #1125:
URL: https://github.com/apache/iceberg/pull/1125#discussion_r446181325
##########
File path:
data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetWriter.java
##########
@@ -284,6 +291,11 @@ public void write(int repetitionLevel, byte[] value) {
}
}
+ public interface StructWriterFactory {
Review comment:
The inheritance version is
[here](https://github.com/apache/iceberg/pull/1125/files/f4799a0000639f662c3df823240c2e27d0734b10).
> I'm curious why you think the other approach looks more concise, though.
Because the inheritance version will need to expose the `buildReader` and
`buildWriter` logic , for example
[this](https://github.com/apache/iceberg/pull/1125/files/f4799a0000639f662c3df823240c2e27d0734b10#diff-aa5e57d56a7b1137c0bd6b1370a1ccaaR42).
If we change those logic, will also need to change in flink reader/writers.
seems the same logic with the GenericParquetReader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
