rdblue commented on a change in pull request #1125:
URL: https://github.com/apache/iceberg/pull/1125#discussion_r445706825
##########
File path:
data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetWriter.java
##########
@@ -284,6 +291,11 @@ public void write(int repetitionLevel, byte[] value) {
}
}
+ public interface StructWriterFactory {
Review comment:
Could you post the branch with the inheritance version? I'd like to see
it to compare. I don't like the extra public classes and methods, and I think
that inheritance would be a cleaner public API. I'm curious why you think the
other approach looks more concise, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
