rdblue commented on a change in pull request #1125:
URL: https://github.com/apache/iceberg/pull/1125#discussion_r446304286
##########
File path:
data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetWriter.java
##########
@@ -284,6 +291,11 @@ public void write(int repetitionLevel, byte[] value) {
}
}
+ public interface StructWriterFactory {
Review comment:
Okay, how about inheriting from the outer class, then? That way, the
interface and the method that accepts the factory could be `protected`. Mainly,
I don't think these should be public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
