rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479420342
##########
File path: core/src/main/java/org/apache/iceberg/CachingCatalog.java
##########
@@ -63,7 +66,10 @@ private TableIdentifier
canonicalizeIdentifier(TableIdentifier tableIdentifier)
@Override
public Table loadTable(TableIdentifier ident) {
- return tableCache.get(canonicalizeIdentifier(ident), catalog::loadTable);
+ Table result = tableCache.get(canonicalizeIdentifier(ident),
catalog::loadTable);
+ LOG.info("Table loaded by catalog: {}", result);
Review comment:
I think this is misleading. What we want to know is whether a cached
version of the table was used or whether the catalog loaded the table. The
catalog should log when it loads a table, so this just needs to log when there
was a cache hit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
