rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479420789
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopTables.java
##########
@@ -71,20 +74,24 @@ public HadoopTables(Configuration conf) {
*/
@Override
public Table load(String location) {
+ Table result;
Pair<String, MetadataTableType> parsedMetadataType =
parseMetadataType(location);
if (parsedMetadataType != null) {
// Load a metadata table
- return loadMetadataTable(parsedMetadataType.first(),
parsedMetadataType.second());
+ result = loadMetadataTable(parsedMetadataType.first(),
parsedMetadataType.second());
} else {
// Load a normal table
TableOperations ops = newTableOps(location);
if (ops.current() != null) {
- return new BaseTable(ops, location);
+ result = new BaseTable(ops, location);
} else {
throw new NoSuchTableException("Table does not exist at location: " +
location);
}
}
+
+ LOG.info("Table loaded by HadoopTables: {}", result);
Review comment:
`HadoopTables` is logging this message, so there is no need to add it
here. Also, can we log the location instead of the table instance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
