rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r479422313
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -138,9 +143,11 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
dropTableData(ops.io(), lastMetadata);
}
+ LOG.info("Dropped table: {}", identifier);
return true;
} catch (NoSuchTableException | NoSuchObjectException e) {
+ LOG.debug("Skipping drop, table does not exist: {}", identifier, e);
Review comment:
Should this be info?
I doubt that this is much help if you have to turn debug on and re-run
because whether the table exists is external and modified by this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
